buzz-acp: add Codex Auto-review reviewer option - #3715
Open
skyerus wants to merge 1 commit into
Open
Conversation
Expose Codex approval-reviewer selection independently from ACP permission modes. Merge the selected reviewer into generated CODEX_CONFIG while preserving the existing sandbox and parent-environment precedence. Co-authored-by: Skye Gill <gill.skye95@gmail.com> Signed-off-by: Skye Gill <gill.skye95@gmail.com>
Author
|
The fork-triggered workflows are waiting for maintainer approval:
The PR head is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buzz-acpapprovals_reviewer = "auto_review"into Buzz-generatedCODEX_CONFIGwithout changing ACP sandbox or permission modesCODEX_CONFIGmerge precedenceWhy
This is the Codex follow-up to #2884 and #2885. Those changes add Claude ACP's
autopermission mode, butcodex-acpdoes not advertise that ACP mode. Codex exposes Approve for me separately throughapprovals_reviewer = "auto_review".References:
Configuration
--codex-approvals-reviewer auto-reviewBUZZ_ACP_CODEX_APPROVALS_REVIEWER=auto_reviewuserexplicitly restores manual reviewThis swaps the reviewer for eligible approval requests; it does not widen the sandbox. The existing parent
CODEX_CONFIGcollision precedence is preserved.Verification
Verified at
9ca98dda034cb627dce44d73e99a48714f0dc95b:cargo fmt -p buzz-acp -- --checkcargo clippy -p buzz-acp --lib --all-features -- -D warningscargo test -p buzz-acp -- --test-threads=1(646 library tests and 9 integration tests passed)just cirecipes passed; after the local disk filled while linking the final Tauri test target, completed build artifacts were removed and the remainingjust desktop-tauri-test web-build mobile-testrecipes passed at the same commitCloses #3710.
Related: #2884, #2885.